Update stdsimd #57808
Merged
Update stdsimd #57808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
gnzlbg
force-pushed
the
ustdsimd
branch
2 times, most recently
from
160a34c
to
4e7110b
Compare
gnzlbg
commented
Jan 22, 2019
| @@ -365,6 +368,8 @@ pub mod prelude; | |||
| // Public module declarations and re-exports | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub use core::any; | |||
| #[stable(feature = "simd_arch", since = "1.27.0")] | |||
| pub use core::arch; | |||
There was a problem hiding this comment.
This is the largest change here. Instead of re-compiling core::arch again and including it two times, one in std and one in core, this PR changes libstd to re-export the intrinsics from core directly.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
To make sure I understand what's going on here, is the idea that |
|
The idea is that The run-time feature detection macros (e.g. The |
|
So I've reverted the code that added cfg-if as a dependency and updated this with stdsimd upstream. Hopefully the update goes smoothly. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Ok sounds good to me! Can you double-check locally that |
|
@alexcrichton I've made std::detect unstable, and added a test that exercises the feature detection macros to libstd. The test pass locally for me and I've verified the output manually on my machine. The test should break on CI because the non-x86 macros are unstable |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: delegate+ r+ Looks and sounds great to me! |
|
📌 Commit 08310e7cdde17d58925347d083a09014c97afa7a has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
|
✌️ @gnzlbg can now approve this pull request |
bors
added
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: r- |
bors
added
S-waiting-on-author
|
@bors p=1 |
|
⌛ Testing commit f4ed39ca06f86a1b46a1036fde507ccb381529c5 with merge 49ee342497e3db2ef201f099b9dc33fc7f20c858... |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: r+ |
|
📌 Commit 938a814 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 938a814 with merge e96c5f7f7434ed8d985413f2b8b4444861008ee7... |
|
💔 Test failed - checks-travis |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
@bors: retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 29, 2019
Update stdsimd This is the companion PR to rust-lang/stdarch#640 r? @alexcrichton
|
☀️ Test successful - checks-travis, status-appveyor |
dgreid
pushed a commit
to dgreid/crosvm
that referenced
this pull request
Feb 25, 2020
Use the Rust __cpuid and __cpuid_count intrinsics to replace the C implementation in host_cpuid.c. These are defined in core, but they are also re-exported in std, despite being undocumented there due to technical reasons: rust-lang/rust#57808 (comment) Use the std version for consistency (we don't currently use anything from core anywhere else in crosvm). BUG=None TEST=cargo test -p x86_64 TEST=Boot crosvm on x86_64 Change-Id: Ic7a1094d1b804304a2944f8ee1fe55c5e2db23e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2067159 Reviewed-by: Zach Reizner <zachr@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to rust-lang/stdarch#640
r? @alexcrichton